Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync PR for release 24.11.0 #4599

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Sync PR for release 24.11.0 #4599

merged 2 commits into from
Nov 21, 2024

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Nov 21, 2024

Syncing changelog updates and git history

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kratman

@kratman
Copy link
Contributor Author

kratman commented Nov 21, 2024

This will need to be merged instead of squashed. I will do that as soon as RTD is done

@kratman kratman merged commit 103e94f into develop Nov 21, 2024
32 of 35 checks passed
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 99.73136% with 4 lines in your changes missing coverage. Please review.

Project coverage is 99.25%. Comparing base (0e50894) to head (5b1ef70).
Report is 177 commits behind head on develop.

Files with missing lines Patch % Lines
src/pybamm/simulation.py 90.62% 3 Missing ⚠️
...els/submodels/particle_mechanics/base_mechanics.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4599      +/-   ##
===========================================
- Coverage    99.42%   99.25%   -0.18%     
===========================================
  Files          292      302      +10     
  Lines        22215    22906     +691     
===========================================
+ Hits         22087    22735     +648     
- Misses         128      171      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants