Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: pybamm.Simulation.set_parameters and pybamm.Simulation.set_up_and_parameterise_experiment made private in simulation.py #4489

Merged
merged 12 commits into from
Nov 19, 2024

Fix some typos

4051fb6
Select commit
Loading
Failed to load commit list.
Merged

[Bug]: pybamm.Simulation.set_parameters and pybamm.Simulation.set_up_and_parameterise_experiment made private in simulation.py #4489

Fix some typos
4051fb6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 19, 2024 in 0s

66.66% of diff hit (target 99.26%)

View this Pull Request on Codecov

66.66% of diff hit (target 99.26%)

Annotations

Check warning on line 181 in src/pybamm/simulation.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/pybamm/simulation.py#L179-L181 

Added lines #L179 - L181 were not covered by tests
View more details on Codecov