Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: pybamm.Simulation.set_parameters and pybamm.Simulation.set_up_and_parameterise_experiment made private in simulation.py #4489

Merged

Fix some typos

4051fb6
Select commit
Loading
Failed to load commit list.
Merged
Codecov / codecov/project failed Nov 19, 2024 in 1s

99.25% (-0.02%) compared to bcdd0b5

View this Pull Request on Codecov

99.25% (-0.02%) compared to bcdd0b5

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.25%. Comparing base (bcdd0b5) to head (4051fb6).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/pybamm/simulation.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4489      +/-   ##
===========================================
- Coverage    99.26%   99.25%   -0.02%     
===========================================
  Files          302      302              
  Lines        22889    22897       +8     
===========================================
+ Hits         22721    22726       +5     
- Misses         168      171       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features: