Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jax tests #3962

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Fix Jax tests #3962

merged 2 commits into from
Apr 3, 2024

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Apr 3, 2024

Description

Gets the Jax tests up and running again so we can working fixing the problem

Related #3959

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman kratman self-assigned this Apr 3, 2024
@kratman kratman changed the title Changing Jax version Fix Jax tests Apr 3, 2024
@kratman kratman marked this pull request as ready for review April 3, 2024 18:59
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (78b7d25) to head (b0cbfc5).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3962   +/-   ##
========================================
  Coverage    99.58%   99.58%           
========================================
  Files          257      257           
  Lines        21196    21196           
========================================
  Hits         21108    21108           
  Misses          88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could we open an issue for unpinning SciPy to track that before v24.5?

@kratman
Copy link
Contributor Author

kratman commented Apr 3, 2024

Thanks, could we open an issue for unpinning SciPy to track that before v24.5?

I plan to unpin it when we close the Jax issue. I will add a comment on there for it

@kratman kratman merged commit 6bb959c into pybamm-team:develop Apr 3, 2024
46 checks passed
@agriyakhetarpal agriyakhetarpal deleted the fix/Jax branch April 3, 2024 20:42
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this pull request Aug 12, 2024
* Changing Jax version

* Temporary fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants