-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for python 3.8 #3961
Conversation
I merged #3962 into this one to get the tests running faster |
Also, I remember that there were some notes that we had added about the JAX solver not being available for Python 3.8, we should be able to remove those too now (can't find where exactly they were in the installation docs) |
I think I removed them all. I can double check though |
Found them, they are in |
Co-authored-by: Agriya Khetarpal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm not aware of the typing stuff but it looks okay to me since pre-commit
is passing.
That was done by pre-commit. I guess it detected that I removed 3.8 support and switched a bunch of stuff |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3961 +/- ##
========================================
Coverage 99.58% 99.58%
========================================
Files 257 257
Lines 21196 21198 +2
========================================
+ Hits 21108 21110 +2
Misses 88 88 ☔ View full report in Codecov by Sentry. |
* Remove python 3.8 * More nox fixes * style: pre-commit fixes * Pre-commit * Pre-commit fixes * Changing Jax version * Temporary fix * Remove notes * Apply suggestions from code review Co-authored-by: Agriya Khetarpal <[email protected]> * Update .github/workflows/update_version.yml --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Agriya Khetarpal <[email protected]>
Description
Removes support for python 3.8
Fixes #3390
Type of change
This is a breaking change since it reduces support for a python version. On the plus side it reduces the number of CI jobs.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: