Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Prada parameter set #3096

Merged
merged 2 commits into from
Jul 5, 2023
Merged

fix Prada parameter set #3096

merged 2 commits into from
Jul 5, 2023

Conversation

valentinsulzer
Copy link
Member

@valentinsulzer valentinsulzer commented Jul 4, 2023

Description

The Prada2013 parameter set was a mix of different papers that gave inconsistent results.
It now matches the parameters from the Prada2013 paper, except OCPs which are not given in the paper.
The exchange-current densities are also from a different paper since the values they give in the paper are strange.
Removed thermal parameters since they don't have a thermal model. We should make it clear when thermal parameters just come from the default set we use everywhere

Fixes #1811

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (72067f3) 99.71% compared to head (8e9b7df) 99.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3096      +/-   ##
===========================================
- Coverage    99.71%   99.71%   -0.01%     
===========================================
  Files          248      248              
  Lines        18749    18747       -2     
===========================================
- Hits         18695    18693       -2     
  Misses          54       54              
Impacted Files Coverage Δ
pybamm/input/parameters/lithium_ion/Prada2013.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@valentinsulzer valentinsulzer merged commit 65d3944 into develop Jul 5, 2023
@valentinsulzer valentinsulzer deleted the fix-prada branch July 5, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prada2013 LFP Cell data
2 participants