Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prada2013 LFP Cell data #1811

Closed
rmahbub opened this issue Nov 17, 2021 · 1 comment · Fixed by #3096
Closed

Prada2013 LFP Cell data #1811

rmahbub opened this issue Nov 17, 2021 · 1 comment · Fixed by #3096
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows

Comments

@rmahbub
Copy link

rmahbub commented Nov 17, 2021

I am a little confused if the active material fraction is correct in the CSV file of LFP positive electrode (Prada 2013). For example, for Prada2013 (A123 M1A LFP Cell) positive active material fraction is 0.28 and porosity fraction is 0.12 in the csv file. Lain2019 in his paper says that the cathode composition in M1A cell is active:binder:carbon=79:11:10. Can you comment on this mismatch
@valentinsulzer
Copy link
Member

The values there are fitted to the data from the Severson 2019 Nature Energy paper. We should change them to the ones from the Lain paper. Can you open a PR doing this?

@brosaplanella brosaplanella added the difficulty: easy A good issue for someone new. Can be done in a few hours label Mar 10, 2022
valentinsulzer added a commit that referenced this issue Aug 1, 2022
@valentinsulzer
#1811 update Prada parameter set
eabb720
@rtimms rtimms added the priority: medium To be resolved if time allows label May 15, 2023
@valentinsulzer valentinsulzer mentioned this issue Jul 4, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix Prada parameter set pybamm-team/PyBaMM
4 participants
@valentinsulzer @rmahbub @brosaplanella @rtimms