Issue 1651 remove domain #1654
Merged
Issue 1651 remove domain #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1654 +/- ##
===========================================
+ Coverage 99.26% 99.27% +0.01%
===========================================
Files 343 342 -1
Lines 18677 18717 +40
===========================================
+ Hits 18540 18582 +42
+ Misses 137 135 -2
Continue to review full report at Codecov.
|
rtimms
approved these changes
Sep 10, 2021
| " 'Negative electrode lithium plating interfacial current density [A.m-2]',\n", | ||
| " 'X-averaged negative electrode lithium plating interfacial current density',\n", | ||
| " 'X-averaged negative electrode lithium plating interfacial current density [A.m-2]',\n", | ||
| " 'lithium plating concentration',\n", |
There was a problem hiding this comment.
Very minor, but should "lithium" have a capital "L" for consistency with other names?
examples/scripts/custom_model.py
Outdated
| model.submodels["negative sei"] = pybamm.sei.NoSEI(model.param, "Negative") | ||
| model.submodels["positive sei"] = pybamm.sei.NoSEI(model.param, "Positive") | ||
| model.submodels["negative sei"] = pybamm.sei.NoSEI(model.param) | ||
| model.submodels["positive sei"] = pybamm.sei.NoSEI(model.param) |
There was a problem hiding this comment.
can this be removed? looks like we don't need to set it in the lithium-ion models anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1651
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: