Issue 1505 porosity #1617
Merged
Issue 1505 porosity #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brosaplanella
commented
Aug 24, 2021
| ), | ||
| ( | ||
| "Charge at 1 C until 4.2 V", | ||
| "Hold at 4.2 V until C/20", | ||
| "Rest for 30 minutes", | ||
| "Discharge at 3 C until 2.8 V", | ||
| "Discharge at 3 C until 2.8 V (10 second period)", | ||
| "Rest for 30 minutes", |
There was a problem hiding this comment.
Had to add the rest periods and reduce the sampling period at discharge, otherwise simulations didn't converge.
Codecov Report
@@ Coverage Diff @@
## develop #1617 +/- ##
========================================
Coverage 97.99% 97.99%
========================================
Files 327 328 +1
Lines 18665 18676 +11
========================================
+ Hits 18290 18301 +11
Misses 375 375
Continue to review full report at Codecov.
|
brosaplanella
commented
Aug 24, 2021
Comment on lines
69
to
75
| # Reaction driven porosity ODE for lithium-ion is not supported at the moment | ||
| # if self.options["SEI porosity change"] == "true": | ||
| # beta_sei_n = self.param.beta_sei_n | ||
| # deps_n_dt += beta_sei_n * j_sei_n | ||
| # if self.options["lithium plating porosity change"] == "true": | ||
| # beta_plating = self.param.beta_plating | ||
| # deps_n_dt += beta_plating * j_plating |
There was a problem hiding this comment.
I commented it out as it is not used. Should I delete it? Because it is checking the options rather than the submodels at the moment there is no way we can enter these if statements.
brosaplanella
commented
Aug 24, 2021
valentinsulzer
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
Thanks @brosaplanella ! Just remove the commented out lines then we can merge
Comment on lines
69
to
75
| # Reaction driven porosity ODE for lithium-ion is not supported at the moment | ||
| # if self.options["SEI porosity change"] == "true": | ||
| # beta_sei_n = self.param.beta_sei_n | ||
| # deps_n_dt += beta_sei_n * j_sei_n | ||
| # if self.options["lithium plating porosity change"] == "true": | ||
| # beta_plating = self.param.beta_plating | ||
| # deps_n_dt += beta_plating * j_plating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write reaction driven porosity as a function of the plated & SEI thicknesses for lithium-ion models (lead-acid stays the same).
Fixes #1505
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: