Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat porosity model for SEI/plating #1505

Closed
valentinsulzer opened this issue Jun 5, 2021 · 0 comments · Fixed by #1617
Closed

Reformat porosity model for SEI/plating #1505

valentinsulzer opened this issue Jun 5, 2021 · 0 comments · Fixed by #1617
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

Should not be its own ODE but instead proportional to SEI thickness and plating thickness
@valentinsulzer valentinsulzer self-assigned this Jun 8, 2021
valentinsulzer added a commit that referenced this issue Jun 8, 2021
@valentinsulzer
#1505 reformatted model but getting different answers
bc5bdc3
valentinsulzer added a commit that referenced this issue Aug 12, 2021
@valentinsulzer
#1505 merge develop
97d80b2
brosaplanella added a commit that referenced this issue Aug 23, 2021
@brosaplanella
#1505 modified porosity submodel but still not fully working
371583b
brosaplanella added a commit that referenced this issue Aug 23, 2021
@brosaplanella
#1505 update but still not working
1e47276
brosaplanella added a commit that referenced this issue Aug 23, 2021
@brosaplanella
#1505 removed sphere model and just kept planar
4e8fa90
brosaplanella added a commit that referenced this issue Aug 23, 2021
@brosaplanella
#1505 fix lead-acid models
3a11b17
brosaplanella added a commit that referenced this issue Aug 23, 2021
@brosaplanella
#1505 fix porosity tests
61342dc
brosaplanella added a commit that referenced this issue Aug 23, 2021
@brosaplanella
#1505 fix example calendar aging
ee12500
@brosaplanella brosaplanella mentioned this issue Aug 23, 2021
Merged
6 tasks
brosaplanella added a commit that referenced this issue Aug 24, 2021
@brosaplanella
#1505 revert calendar ageing
825ec71
brosaplanella added a commit that referenced this issue Aug 24, 2021
@brosaplanella
#1505 fix example
b039fb8
brosaplanella added a commit that referenced this issue Aug 24, 2021
@brosaplanella
#1505 fix coverage
701a224
brosaplanella added a commit that referenced this issue Aug 24, 2021
@brosaplanella
#1505 removed SEI and plating lines
d8b3736
brosaplanella added a commit that referenced this issue Aug 24, 2021
@brosaplanella
#1505 update CHANGELOG
7a2dc5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1505 porosity pybamm-team/PyBaMM
1 participant
@valentinsulzer