-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1477 sensitivities for solvers #1552
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THanks for taking this on @martinjrobins ! Just a few comments
tests/integration/test_models/test_full_battery_models/test_lithium_ion/test_dfn.py
Outdated
Show resolved
Hide resolved
valentinsulzer
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Will just need to merge develop after #1596 to fix the github actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds functionality to calculate sensitivities. Specifically:
pybamm.base_solver.solve
function can take a list of input parameters to calculate the sensitivities of the solution with respect to. Or it can beTrue
to calculate the sensitivities for all input parameters. If this arg changes between different calls tosolve
, then the model is re-setup.model.convert_to_format = 'casadi'
, then sensitivities will be calculated by solving the explicit forward sensitivity equations. Any solver can be used, except for the IDKLU solver which uses CVODES forward sensitivity methods, see next itemmodel.convert_to_format = 'casadi'
ormodel.convert_to_format = 'jax'
, the IDKLU solver can use the CVODES package to calculate sensitivities.Fixes #1477
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: