Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latexify notebook #1596

Merged
merged 10 commits into from
Aug 18, 2021

Conversation

priyanshuone6
Copy link
Member

Description

Add latexify notebook in examples

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@priyanshuone6 priyanshuone6 marked this pull request as draft August 8, 2021 17:19
@priyanshuone6 priyanshuone6 marked this pull request as ready for review August 10, 2021 01:30
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #1596 (b8ea482) into develop (4ebecbc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1596   +/-   ##
========================================
  Coverage    97.92%   97.93%           
========================================
  Files          324      324           
  Lines        18150    18221   +71     
========================================
+ Hits         17773    17844   +71     
  Misses         377      377           
Impacted Files Coverage Δ
pybamm/expression_tree/binary_operators.py 99.51% <100.00%> (ø)
pybamm/expression_tree/concatenations.py 98.25% <100.00%> (ø)
pybamm/expression_tree/functions.py 100.00% <100.00%> (ø)
pybamm/expression_tree/independent_variable.py 100.00% <100.00%> (ø)
pybamm/expression_tree/operations/latexify.py 100.00% <100.00%> (ø)
pybamm/expression_tree/parameter.py 100.00% <100.00%> (ø)
pybamm/expression_tree/printing/print_name.py 100.00% <100.00%> (ø)
pybamm/expression_tree/scalar.py 100.00% <100.00%> (ø)
pybamm/expression_tree/symbol.py 98.25% <100.00%> (ø)
pybamm/expression_tree/unary_operators.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebecbc...b8ea482. Read the comment docs.

@priyanshuone6
Copy link
Member Author

All done, it is ready to be reviewed now

@@ -44,6 +44,7 @@ jobs:
- name: Install Linux system dependencies
if: matrix.os == 'ubuntu-latest'
run: |
sudo apt-get update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge when tests pass

@valentinsulzer valentinsulzer merged commit 6f4a152 into pybamm-team:develop Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants