Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose additional variables #1546

Merged
merged 8 commits into from
Jul 15, 2021
Merged

Expose additional variables #1546

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d4dccba
Expose additional variables
molel-gt Jul 13, 2021
ff11345
Remove flux
molel-gt Jul 13, 2021
9737a7a
Rename var
molel-gt Jul 13, 2021
4e7d71f
Remove variables that are parameters
molel-gt Jul 14, 2021
520b0aa
Fix flake8 style issues
molel-gt Jul 14, 2021
1639c08
Merge branch 'develop' into issue-1527-expose-more-variables
valentinsulzer Jul 14, 2021
dfc11ba
Add current density dimension
molel-gt Jul 14, 2021
c2baee9
Merge branch 'issue-1527-expose-more-variables' of github.com:molel-g…
molel-gt Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pybamm/models/full_battery_models/lithium_ion/basic_dfn_half_cell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,7 @@ def __init__(self, name="Doyle-Fuller-Newman half cell model", options=None):
* param.L_s
* param.A_cc,
"Current [A]": I,
"Current density [A.m-2]": i_cell,
"Working electrode potential": phi_s_w,
"Working electrode potential [V]": phi_s_w_ref + pot * phi_s_w,
"Working electrode open circuit potential": U_w(c_s_surf_w, T),
Expand All @@ -367,6 +368,10 @@ def __init__(self, name="Doyle-Fuller-Newman half cell model", options=None):
+ pot * vdrop_cell,
"Terminal voltage": voltage,
"Terminal voltage [V]": phi_s_w_ref + param.U_n_ref + pot * voltage,
"Instantaneous power [W.m-2]": i_cell * i_typ * (phi_s_w_ref + param.U_n_ref + pot * voltage),
"Pore-wall flux [mol.m-2.s-1]": j_w,
"Ratio of electrolyte diffusion to discharge time": param.C_e,
"Ratio of solid diffusion to discharge time": param.C_p,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can print parameters to a file like this

PyBaMM/tests/unit/test_parameters/test_lithium_ion_parameters.py

Lines 12 to 15 in d62c862

parameters = pybamm.LithiumIonParameters()
parameter_values = pybamm.lithium_ion.BaseModel().default_parameter_values
output_file = "lithium_ion_parameters.txt"
parameter_values.print_parameters(parameters, output_file)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you don't need to add these to the list of variables

}

@property
Expand Down