Expose additional variables

[molel-gt]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[valentinsulzer]

you can print parameters to a file like this

PyBaMM/tests/unit/test_parameters/test_lithium_ion_parameters.py

Lines 12 to 15 in d62c862

	parameters = pybamm.LithiumIonParameters()
	parameter_values = pybamm.lithium_ion.BaseModel().default_parameter_values
	output_file = "lithium_ion_parameters.txt"
	parameter_values.print_parameters(parameters, output_file)

[molel-gt]

Thanks.

[valentinsulzer]

So you don't need to add these to the list of variables

[valentinsulzer]

Tests won't run until conflicts are resolved

[codecov]

Codecov Report

Merging #1546 (c2baee9) into develop (bae3720) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1546   +/-   ##
========================================
  Coverage    98.28%   98.28%           
========================================
  Files          310      310           
  Lines        17401    17401           
========================================
  Hits         17102    17102           
  Misses         299      299           

Impacted Files	Coverage Δ
..._battery_models/lithium_ion/basic_dfn_half_cell.py	99.36% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae3720...c2baee9. Read the comment docs.

[valentinsulzer]

Looks good, is this ready to merge once conflicts are resolved?

[molel-gt]

Looks good, is this ready to merge once conflicts are resolved?

Yes.

[valentinsulzer]

@all-contributors add @molel-gt for code, ideas

[allcontributors]

@tinosulzer

I've put up a pull request to add @molel-gt! 🎉