Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Other" changes from the julia branch #1497

Merged
merged 134 commits into from
Jun 3, 2021

Conversation

valentinsulzer
Copy link
Member

Description

The Julia branch is not ready yet, but there are some other changes that might be useful for the print-equations project that I would like to merge in (mainly, defining "print_name" for other variables)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #1497 (2e4f5e4) into develop (28de127) will increase coverage by 0.00%.
The diff coverage is 99.19%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1497   +/-   ##
========================================
  Coverage    98.34%   98.34%           
========================================
  Files          296      296           
  Lines        17104    17141   +37     
========================================
+ Hits         16821    16858   +37     
  Misses         283      283           
Impacted Files Coverage Δ
pybamm/solvers/casadi_solver.py 100.00% <ø> (ø)
pybamm/util.py 100.00% <ø> (ø)
...bamm/expression_tree/operations/evaluate_python.py 97.78% <80.00%> (ø)
pybamm/__init__.py 94.95% <100.00%> (ø)
pybamm/expression_tree/concatenations.py 98.13% <100.00%> (+0.07%) ⬆️
pybamm/expression_tree/functions.py 100.00% <100.00%> (ø)
pybamm/expression_tree/parameter.py 100.00% <100.00%> (ø)
pybamm/expression_tree/scalar.py 100.00% <100.00%> (ø)
pybamm/expression_tree/variable.py 100.00% <100.00%> (ø)
pybamm/models/base_model.py 99.23% <100.00%> (+<0.01%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28de127...2e4f5e4. Read the comment docs.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tinosulzer , looks good!

T = pybamm.concatenation(T_n, T_s, T_p)
T_av = pybamm.Variable("X-averaged cell temperature", domain="current collector")
T_vol_av = pybamm.Variable("Volume-averaged cell temperature")
# self.eps_piecewise_constant = pybamm.concatenation(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this and the concatenation for T be removed?

@valentinsulzer valentinsulzer merged commit 08de417 into develop Jun 3, 2021
@valentinsulzer valentinsulzer deleted the other-changes-julia-branch branch June 3, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants