-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Other" changes from the julia branch #1497
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1497 +/- ##
========================================
Coverage 98.34% 98.34%
========================================
Files 296 296
Lines 17104 17141 +37
========================================
+ Hits 16821 16858 +37
Misses 283 283
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @tinosulzer , looks good!
pybamm/models/standard_variables.py
Outdated
T = pybamm.concatenation(T_n, T_s, T_p) | ||
T_av = pybamm.Variable("X-averaged cell temperature", domain="current collector") | ||
T_vol_av = pybamm.Variable("Volume-averaged cell temperature") | ||
# self.eps_piecewise_constant = pybamm.concatenation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this and the concatenation for T
be removed?
Description
The Julia branch is not ready yet, but there are some other changes that might be useful for the print-equations project that I would like to merge in (mainly, defining "print_name" for other variables)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: