Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
valentinsulzer committed Jun 3, 2021
1 parent 5956cb1 commit 2e4f5e4
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Features

- Added `print_name` to some symbols ([#1495](https://github.com/pybamm-team/PyBaMM/pull/1497), [#1495](https://github.com/pybamm-team/PyBaMM/pull/1497))
- Added Base Parameters class and SymPy in dependencies ([#1495](https://github.com/pybamm-team/PyBaMM/pull/1495))
- Added a new "reaction-driven" model for LAM from Reniers et al (2019) ([#1490](https://github.com/pybamm-team/PyBaMM/pull/1490))
- Some features ("loss of active material" and "particle mechanics") can now be specified separately for the negative electrode and positive electrode by passing a 2-tuple ([#1490](https://github.com/pybamm-team/PyBaMM/pull/1490))
Expand Down
9 changes: 0 additions & 9 deletions pybamm/models/standard_variables.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ def __init__(self):
domain="positive electrode",
auxiliary_domains={"secondary": "current collector"},
)
# self.phi_e = pybamm.concatenation(phi_e_n, phi_e_s, phi_e_p)

# Electrode potential
self.phi_s_n = pybamm.Variable(
Expand Down Expand Up @@ -249,7 +248,6 @@ def __init__(self):
auxiliary_domains={"secondary": "current collector"},
bounds=(0, 1),
)
# self.eps = pybamm.concatenation(eps_n, eps_s, eps_p)

# Piecewise constant (for asymptotic models)
self.eps_n_pc = pybamm.Variable(
Expand All @@ -266,12 +264,6 @@ def __init__(self):
bounds=(0, 1),
)

# self.eps_piecewise_constant = pybamm.concatenation(
# pybamm.PrimaryBroadcast(eps_n_pc, "negative electrode"),
# pybamm.PrimaryBroadcast(eps_s_pc, "separator"),
# pybamm.PrimaryBroadcast(eps_p_pc, "positive electrode"),
# )

# Temperature
self.T_cn = pybamm.Variable(
"Negative currents collector temperature", domain="current collector"
Expand All @@ -294,7 +286,6 @@ def __init__(self):
self.T_cp = pybamm.Variable(
"Positive currents collector temperature", domain="current collector"
)
# self.T = pybamm.concatenation(T_n, T_s, T_p)
self.T_av = pybamm.Variable(
"X-averaged cell temperature", domain="current collector"
)
Expand Down

0 comments on commit 2e4f5e4

Please sign in to comment.