Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

length scales for effective current collector model #1070

Closed
rtimms opened this issue Jun 23, 2020 · 0 comments · Fixed by #1071
Closed

length scales for effective current collector model #1070

rtimms opened this issue Jun 23, 2020 · 0 comments · Fixed by #1071
Assignees
@rtimms
Labels
bug Something isn't working

Comments

@rtimms
Copy link
Contributor

rtimms commented Jun 23, 2020

the length scales for the effective current collector model are just the defaults (1[m]), but should be set to L_z to match other battery models
@rtimms rtimms added the bug Something isn't working label Jun 23, 2020
@rtimms rtimms self-assigned this Jun 23, 2020
rtimms added a commit that referenced this issue Jun 23, 2020
@rtimms
#1070 add length scales
5a0f56e
@rtimms rtimms mentioned this issue Jun 23, 2020
Merged
8 tasks
rtimms added a commit that referenced this issue Jun 23, 2020
@rtimms
#1070 changelog
c559519
rtimms added a commit that referenced this issue Jun 23, 2020
@rtimms
Merge pull request #1071 from pybamm-team/issue-1070-effective-cc-len…
5585046 
…gthscale

#1070 add length scales
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtimms rtimms

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1070 add length scales pybamm-team/PyBaMM
1 participant
@rtimms