#1070 add length scales

pybamm-team · Jun 23, 2020 · 5a0f56e · 5a0f56e
1 parent 6c7a06e
commit 5a0f56e
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 24 deletions.
diff --git a/examples/notebooks/models/pouch-cell-model.ipynb b/examples/notebooks/models/pouch-cell-model.ipynb
diff --git a/pybamm/models/submodels/current_collector/effective_resistance_current_collector.py b/pybamm/models/submodels/current_collector/effective_resistance_current_collector.py
@@ -40,6 +40,12 @@ def __init__(
         self.options = options
         self.param = pybamm.standard_parameters_lithium_ion
 
+        # Set default length scales
+        self.length_scales = {
+            "current collector y": self.param.L_y,
+            "current collector z": self.param.L_z,
+        }
+
         self.variables = self.get_fundamental_variables()
         self.set_algebraic(self.variables)
         self.set_boundary_conditions(self.variables)

diff --git a/pybamm/parameters/standard_parameters_lead_acid.py b/pybamm/parameters/standard_parameters_lead_acid.py
@@ -442,7 +442,8 @@ def j0_p_Ox_dimensional(c_e, T):
 rho_cp = pybamm.thermal_parameters.rho_cp
 
 rho_k = pybamm.thermal_parameters.rho_k
-rho = rho_n * l_n + rho_s * l_s + rho_p * l_p
+# effective volumetric heat capacity
+rho = (rho_cn * l_cn + rho_n * l_n + rho_s * l_s + rho_p * l_p + rho_cp * l_cp) / l
 
 lambda_cn = pybamm.thermal_parameters.lambda_cn
 lambda_n = pybamm.thermal_parameters.lambda_n

diff --git a/pybamm/parameters/standard_parameters_lithium_ion.py b/pybamm/parameters/standard_parameters_lithium_ion.py
@@ -387,7 +387,8 @@ def chi(c_e):
 rho_cp = pybamm.thermal_parameters.rho_cp
 
 rho_k = pybamm.thermal_parameters.rho_k
-rho = rho_n * l_n + rho_s * l_s + rho_p * l_p
+# effective volumetric heat capacity
+rho = (rho_cn * l_cn + rho_n * l_n + rho_s * l_s + rho_p * l_p + rho_cp * l_cp) / l
 
 lambda_cn = pybamm.thermal_parameters.lambda_cn
 lambda_n = pybamm.thermal_parameters.lambda_n