-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pangeo as a partner to our submission form #70
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
75c02bb
Add Pangeo as a partner
lwasser 56d5f0e
Add: pangeo links to submission guide
lwasser 36d0879
Fix conflicts and links
lwasser 491dc52
Add: ci to check links and clearer categories
lwasser 6e23496
Rebase fix conflict
lwasser 1f9661a
Fix: categories on both templates
lwasser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,21 +14,48 @@ Repository Link (if existing): | |
|
||
--- | ||
|
||
## Code of Conduct & Commitment to Maintain Package | ||
|
||
- [ ] I agree to abide by [pyOpenSci's Code of Conduct][PyOpenSciCodeOfConduct] during the review process and in maintaining my package after should it be accepted. | ||
- [ ]I have read and will commit to package maintenance after the review as per the [pyOpenSci Policies Guidelines][Commitment]. | ||
|
||
## Description | ||
|
||
- Include a brief paragraph describing what your package does: | ||
|
||
## Community Partnerships | ||
We partner with communities to support peer review with an additional layer of | ||
checks that satisfy community requirements. If your package fits into an | ||
existing community please check below: | ||
|
||
- [ ] [Pangeo][pangeoWebsite] | ||
- [ ] My package adheres to the [Pangeo standards listed in the pyOpenSci peer review guidebook][PangeoCollaboration] | ||
|
||
## Scope | ||
|
||
- Please indicate which [category or categories][PackageCategories] this package falls under: | ||
|
||
## Scope | ||
- Please indicate which category or categories. | ||
Check out our [package scope page][PackageCategories] to learn more about our | ||
scope. (If you are unsure of which category you fit, we suggest you make a pre-submission inquiry): | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here i'm adjusting our categories based on the scope page that is open for review now here |
||
- [ ] Data retrieval | ||
- [ ] Data extraction | ||
- [ ] Data munging | ||
- [ ] Data processing/munging | ||
- [ ] Data deposition | ||
- [ ] Data visualization | ||
- [ ] Reproducibility | ||
- [ ] Data validation and testing | ||
- [ ] Data visualization ** | ||
- [ ] Workflow automation | ||
- [ ] Citation management and bibliometrics | ||
- [ ] Scientific software wrappers | ||
- [ ] Database interoperability | ||
|
||
Domain Specific & Community Partnerships | ||
|
||
- [ ] Geospatial | ||
- [ ] Education | ||
- [ ] Pangeo | ||
- [ ] Unsure/Other (explain below) | ||
|
||
- Explain how and why the package falls under these categories (briefly, 1-2 sentences). Please note any areas you are unsure of: | ||
|
@@ -40,17 +67,19 @@ Repository Link (if existing): | |
- Any other questions or issues we should be aware of: | ||
|
||
|
||
- [ ] Please make sure that you took notice of our [Community Code of Conduct][Conduct] and are able to commit to the package maintainance as per our [Policies Guidelines][Commitment]. | ||
**P.S.** *Have feedback/comments about our review process? Leave a comment [here][Comments] | ||
|
||
|
||
[PackageCategories]: https://www.pyopensci.org/software-peer-review/about/package-scope.html | ||
|
||
**P.S.** *Have feedback/comments about our review process? Leave a comment [here][Comments] | ||
[Conduct]: https://www.pyopensci.org/governance/CODE_OF_CONDUCT | ||
|
||
[Commitment]: https://www.pyopensci.org/software-peer-review/our-process/policies.html#after-acceptance-package-ownership-and-maintenance | ||
|
||
[PackageCategories]: https://www.pyopensci.org/contributing-guide/open-source-software-peer-review/aims-and-scope.html?highlight=data#package-categories | ||
[Comments]: https://pyopensci.discourse.group/ | ||
|
||
[Conduct]: https://www.pyopensci.org/peer-review-guide/about-peer-review/code-of-conduct.html | ||
[PangeoCollaboration]: https://www.pyopensci.org/software-peer-review/partners/pangeo | ||
|
||
[Commitment]: https://www.pyopensci.org/peer-review-guide/about-peer-review/policies-guidelines.html#after-acceptance-package-ownership-and-maintenance | ||
[pangeoWebsite]: https://www.pangeo.io | ||
|
||
[Comments]: https://github.com/pyOpenSci/governance/issues/8 | ||
[PyOpenSciCodeOfConduct]: https://www.pyopensci.org/governance/CODE_OF_CONDUCT |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
name: check links | ||
|
||
on: | ||
pull_request: | ||
push: | ||
branches: | ||
- main | ||
|
||
jobs: | ||
markdown-link-check: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@master | ||
- uses: gaurav-nelson/github-action-markdown-link-check@v1 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Batalex how does this look? i took the comments from #66 and integrated it here - so at the top of each submission for we have a COC and the maintenance checks. Does that seem like a good approach to you?