-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code of conduct & guidelines refs to presubmission template #66
Conversation
|
||
**P.S.** *Have feedback/comments about our review process? Leave a comment [here][Comments] | ||
|
||
|
||
[PackageCategories]: https://www.pyopensci.org/contributing-guide/open-source-software-peer-review/aims-and-scope.html?highlight=data#package-categories | ||
|
||
[Conduct]: https://www.pyopensci.org/peer-review-guide/about-peer-review/code-of-conduct.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lwasser Am I going too far with this?
On the one hand, "better safe than sorry." On the other, this could seem a bit rough for first contact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh so sorry i didn't respond here @Batalex i'm just seeing this. We actually have a. new COC but our board has to approve it. you can see it here - pyOpenSci/handbook#31
i haven't posted it for review yet because the board wanted to see it first. so i DO NOT think you are going too far! but do you mind if we hold of on merging until i have this new COC in place? i hope in a month that will happen! thank you so much for taking the initiative here to submit this PR i think it is great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not too far at all! i am going to merge this and then will updtae the link as we have a new COC link now. this is awesome @Batalex THANK YOU for it. Sorry it took me some time to get to this pr - i wanted to get the COC approved first and published and such!
|
||
**P.S.** *Have feedback/comments about our review process? Leave a comment [here][Comments] | ||
|
||
|
||
[PackageCategories]: https://www.pyopensci.org/contributing-guide/open-source-software-peer-review/aims-and-scope.html?highlight=data#package-categories | ||
|
||
[Conduct]: https://www.pyopensci.org/peer-review-guide/about-peer-review/code-of-conduct.html | ||
|
||
[Commitment]: https://www.pyopensci.org/peer-review-guide/about-peer-review/policies-guidelines.html#after-acceptance-package-ownership-and-maintenance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is also great! we could even make these things check boxes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you prefer to have two separate checkboxes than one now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think two is preferred. i am updating links locally to the new coc and adding pangeo. how about i add two and then you can have a look at my pr to make sure i'm incorporating what you have here and your ideas about what this should look like!!
@Batalex the wording of things is great! thank you for this. I'm going to push up a new pr soon with a few more added things. would love your review after! |
@all-contributors please add @Batalex for code, design, review |
I've put up a pull request to add @Batalex! 🎉 |
Feel free to reword as needed. Since I am not a native speaker, some turns of phrases may sound odd at times.