Add keep/drop to coefplot and refactor code to improve maintainability
#341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 85.79% 86.13% +0.33%
==========================================
Files 38 52 +14
Lines 3421 4060 +639
==========================================
+ Hits 2935 3497 +562
- Misses 486 563 +77 ☔ View full report in Codecov by Sentry. |
s3alfisc
approved these changes
Mar 4, 2024
s3alfisc
reviewed
Mar 4, 2024
| @@ -78,6 +78,7 @@ ignore = [ | |||
| "D104", # missing docstring in public package | |||
| "SIM110", # Use all instead of `for` loop | |||
| "TRY003", # Avoid specifying long messages outside the exception class | |||
| "D205", # 1 blank line required between summary line and description | |||
There was a problem hiding this comment.
Yes, I also did not love that one ... 😄
s3alfisc
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alex,
I now replace
coefficientsparameter bykeep,drop, andexact_matchfor bothcoefplotandiplotas mentioned in #323.In the mean time, I see there are some references to these two functions in
FixestMultiandFeols. Changing a parameter in the original function requires changing all functions in these modules if calling them explicitly. So I also do a refactor to these codes usefunctools.partialso we don't need to bother syncing the changes all across codebase now.Please feel free to comment or change the code!
Best regards,
Dave