Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace coef argument in plotting functions with drop and keep arguments #323

Closed
s3alfisc opened this issue Feb 25, 2024 · 0 comments · Fixed by #341
Closed

Replace coef argument in plotting functions with drop and keep arguments #323

s3alfisc opened this issue Feb 25, 2024 · 0 comments · Fixed by #341

Comments

@s3alfisc
Copy link
Member

We should make use of regex-based coefficient selection whenever possible.

The coefplot() function and method currently support a coefficients argument - I think it makes sense to deprecate these in favor of drop, keep, and exact_match.

As _select_order_coefs will be a function not only used for etable but also confint and coefplot, maybe it makes sense to move it from summarize.py to dev_utils.py (which is the script in which I collect non-user facing development utilities)?

@Wenzhi-Ding, maybe something for you to pick up? =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant