[Bug fix] Fix dashboard filters to collect options too (getredash#3759)

pushpay · Nov 14, 2019 · c6d18ac · c6d18ac
1 parent 9c8698e
commit c6d18ac
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/client/app/services/dashboard.js b/client/app/services/dashboard.js
@@ -19,13 +19,12 @@ export function collectDashboardFilters(dashboard, queryResults, urlParams) {
         queryFilter.current = urlParams[queryFilter.name];
       }
 
+      const filter = { ...queryFilter };
       if (!_.has(filters, queryFilter.name)) {
-        const filter = { ...queryFilter };
         filters[filter.name] = filter;
+      } else {
+        filters[filter.name].values = _.union(filters[filter.name].values, filter.values);
       }
-
-      // TODO: merge values. -- maybe - intersect??
-      // filters[queryFilter.name].originFilters.push(queryFilter);
     });
   });