Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dashboard filters collects all options too #3759

Merged
merged 1 commit into from
May 6, 2019

Conversation

yoavbls
Copy link
Contributor

@yoavbls yoavbls commented May 3, 2019

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Fix for a bug in the global filter, The global filter collects the first filter that's it
finds in some name and ignores additional options from filters with the same name.

Related Tickets & Documents

Describes in this issue: #2327

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

image

You can see working example in netlify previews.
before
after

@yoavbls yoavbls changed the title Fix dashboard filters to collect all options too Fix: dashboard filters collects all options too May 3, 2019
Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@kravets-levko
Copy link
Collaborator

Works fine, so merged. Thanks!

@indupulikkot
Copy link

hi in which version this is available

@gabrieldutra
Copy link
Member

Hi @indupulikkot, it's available in Redash v8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants