-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parsing v7.0.0, formatters v6.0.0, graphql-client v7.0.0 #1008
Conversation
Should I comment out formatters from the package-set and then we add formatters back in when it upgrades? |
Yes, we typically decide whether to delay upgrading the root package to avoid breaking things downstream or whether to drop things downstream until they can be updated. In this case would you mind if we get the formatters PR merged and then update both in package sets at once? |
Sounds good. |
Looks like this is at least affecting
|
Yeah, what do you think I should do here @thomashoneyman ?
New issue: OxfordAbstracts/purescript-graphql-client#65 |
@jamesdbrock What do you think of leaving that issue open for a week, and if there's no response in that time we can comment out the library and release a new package set, adding For now we could go ahead and comment it out in case there are other failures down the line. |
Thanks for the heads up. I'll remove StringLike today |
@jamesdbrock I think it should be graphql-client v7.0.0 |
0b00440
to
32dbad3
Compare
Disable * markfarrell/parsing-hexidecimal * markfarrell/parsing-uuid
Ok I think this is ready to go now. I'll open issues with @markfarrell when it's merged so he can upgrade his packages. |
I've merged this, and yea we should open issues (or even pull requests if it's simple) against the two disabled libraries. Thanks @jamesdbrock! |
parsing v7.0.0, formatters v6.0.0, graphql-client v7.0.0
Disable