Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parsing v7.0.0 no StringLike class #76

Merged
merged 2 commits into from
Oct 16, 2021
Merged

parsing v7.0.0 no StringLike class #76

merged 2 commits into from
Oct 16, 2021

Conversation

jamesdbrock
Copy link
Member

@jamesdbrock jamesdbrock commented Oct 6, 2021 •
edited
Loading

Description of the change

Upgrade parsing dependency to v7.0.0, remove the StringLike class. https://github.com/purescript-contrib/purescript-parsing/releases/tag/v7.0.0

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@jamesdbrock jamesdbrock mentioned this pull request Oct 6, 2021
Merged
@thomashoneyman
Copy link
Contributor

We need to update the Bower file dependency to v7.0.0 but otherwise 👍

@jamesdbrock jamesdbrock marked this pull request as ready for review October 6, 2021 08:34
thomashoneyman
thomashoneyman reviewed Oct 6, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jamesdbrock @thomashoneyman
Update CHANGELOG.md
b951188 
Co-authored-by: Thomas Honeyman <[email protected]>
@thomashoneyman thomashoneyman merged commit b3bbcbd into purescript-contrib:main Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesdbrock @thomashoneyman