Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings revealed by PureScript v0.14.1 #68

Merged
merged 5 commits into from
May 6, 2021

Conversation

purefunctor
Copy link
Contributor

@purefunctor purefunctor commented Apr 21, 2021

Description of the change
Links to purescript-contrib/governance#37


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@purefunctor
Copy link
Contributor Author

Not entirely sure what to do with:

filter m a. Alternative m Monad m (a Boolean) m a m a
filter f m = m >>= \x → if f x then pure x else empty

Should this be removed or exported?

@JordanMartinez
Copy link
Contributor

What does git blame show for that? If it's not being used, it was likely there when someone was debugging the code or something. I'm leaning towards removing it.

@natefaubion
Copy link
Collaborator

It should be removed.

@purefunctor
Copy link
Contributor Author

What does git blame show for that? If it's not being used, it was likely there when someone was debugging the code or something. I'm leaning towards removing it.

It points to (a squashed) #17; that seems to be the case though so I went ahead and removed it

@thomashoneyman thomashoneyman merged commit 3945c81 into purescript-contrib:main May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants