Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in contrib libraries revealed by v0.14.1 PS release #37

Closed
18 tasks done
JordanMartinez opened this issue Apr 20, 2021 · 6 comments
Closed
18 tasks done

Fix warnings in contrib libraries revealed by v0.14.1 PS release #37

JordanMartinez opened this issue Apr 20, 2021 · 6 comments
Labels
good first issue First-time contributors who are looking to help should work on these issues.

Comments

@JordanMartinez
Copy link
Contributor

JordanMartinez commented Apr 20, 2021 •
edited
Loading

See purescript/purescript#4071 for more context. Here's the list I have using the same methodology:

  • argonaut-generic
  • css
  • formatters
  • machines
  • parsing
  • pathy
  • precise
  • profunctor-lenses
  • quickcheck-laws
  • routing
  • strings-extra
  • uri

Node and Web Libs

  • node-buffer
  • node-fs
  • node-process
  • web-dom-xpath
  • web-html
  • web-xhr
@JordanMartinez JordanMartinez added good first issue First-time contributors who are looking to help should work on these issues. help wanted labels Apr 20, 2021
This was referenced Apr 21, 2021
Merged
Merged
Merged
@JordanMartinez
Copy link
Contributor Author

I've added node and web libraries above, too. The list might be incomplete because I only searched for all libs that started with node- or web- rather than using my original Vlookup approach.

This was referenced May 5, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@JordanMartinez
Copy link
Contributor Author

PRs to all contrib libraries have been submitted.

@JordanMartinez JordanMartinez mentioned this issue May 5, 2021
Merged
4 tasks
@JordanMartinez
Copy link
Contributor Author

All node libraries' PRs have been submitted. Can we start merging some of these open PRs?

This was referenced May 5, 2021
Merged
Merged
Merged
@thomashoneyman
Copy link
Contributor

@JordanMartinez Everything except for precise has been merged and released.

@JordanMartinez
Copy link
Contributor Author

@thomashoneyman Thanks!

@f-f
Copy link
Collaborator

f-f commented May 6, 2021

Thank you both for doing this! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue First-time contributors who are looking to help should work on these issues.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@f-f @JordanMartinez @thomashoneyman