-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Fixes --run-after flag priority issues. #173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one thing we should do for this, is to add some aliases for some of these options (such as -r for running after uploading, or something along the lines of that). I'm honestly not sure what the best abbreviations would be so anybody can feel free to chime in on this.
I'd prefer you didn't modify all the flags in this PR... imo the other aliases should go in a separate one |
I also think having both run after and run screen is confusing because they're mutually exclusive in some cases.
maybe it would be a cleaner solution to fold these two flag options into one enum option
|
The most recent commit adds a class for deprecated options. Can be used for any option that is deprecated by adding/replacing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, was functioning properly in testing.
Summary:
Changes logic statements when deciding which vex.V5Device.FTCompleteOptions argument to pass. Essentially gives the --run-after switch priority over the --run-screen switch in the if/elif/else chain.
Motivation:
Quality of life feature for users that will allow them to make changes and test them more efficiently. Removes the need to go through the controller menu or press buttons on the brain to test changes.
References (optional):
closes #132
Test Plan:
Tested every combination of --run-after and --run-screen switches to verify that new logic works.
The link to a video of the test cases is here: https://drive.google.com/file/d/1mYM6LzFtDHzZ1Jm6cl8S6FvG-k9EKSDa/view?usp=sharing