Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload's run-after switch does nothing #132

Closed
Octogonapus opened this issue Sep 29, 2020 · 4 comments · Fixed by #173
Closed

Upload's run-after switch does nothing #132

Octogonapus opened this issue Sep 29, 2020 · 4 comments · Fixed by #173
Assignees

Comments

@Octogonapus
Copy link

Expected Behavior:

prosv5 u --run-after should cause the program to run after the upload completes successfully.

Actual Behavior:

prosv5 u --run-after uploads the program successfully like normal, but does not run the program after the upload is finished.

Steps to reproduce:

This is reproducible every time. Just run prosv5 u --run-after and observe it has the same behavior as prosv5 u --no-run-after.

System information:

Operating System: Fedora 32

PROS Version: 3.1.4

Additional Information

This happens with hot/cold and monolith.

Screenshots/Output Dumps/Stack Traces

@Sleuth56
Copy link
Contributor

I use a bash alias on my linux PC's. alias upload='prosv5 make; prosv5 upload; prosv5 v5 run' but the command by it's self is prosv5 v5 run.

@Octogonapus
Copy link
Author

I am not sure what you are saying. I understand what prosv5 v5 run does. This issue is about prosv5 u --run-after, which does not work.

@Sleuth56
Copy link
Contributor

I thought you were just trying to upload after you compiled. which prosv5 v5 upload does. I now see that you are reporting that a specific setting in upload is currently broken.

@BennyBot
Copy link
Member

Currently, the --run-screen switch has priority over the --run-after switch. The proper way as of now to immediately run the program after uploading is prosv5 u --run-after --execute, which sets the run-after switch to true and the run-screen switch to false. I am working on making these switches easier to use for future releases 😃.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants