Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MAINT) Ensure each job has a test matrix #374

Merged
merged 1 commit into from
Jan 23, 2023
Merged

(MAINT) Ensure each job has a test matrix #374

merged 1 commit into from
Jan 23, 2023

Conversation

chelnak
Copy link
Contributor

@chelnak chelnak commented Jan 23, 2023

No description provided.

@chelnak chelnak requested a review from a team as a code owner January 23, 2023 15:51
@chelnak chelnak self-assigned this Jan 23, 2023
ekohl
ekohl reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also run on Ruby 3, 3.1? I'm not sure if it's 3.2 compatible yet, but that would be great to know as well. I always run on my developer machine with a simple bundle install and Fedora 36 and 37 have Ruby 3.

@chelnak
Copy link
Contributor Author

chelnak commented Jan 23, 2023

We can try! I

@chelnak chelnak mentioned this pull request Jan 23, 2023
Merged
@chelnak
Copy link
Contributor Author

chelnak commented Jan 23, 2023

@ekohl on the topic of 3.2.. after some thought I'm not going to be adding in this PR.

Appreciate that might be frustrating.. however this is something we will be rolling out across the board very soon.

@ekohl
Copy link
Contributor

ekohl commented Jan 23, 2023

I don't mind about 3.2 (since I know it can break a lot), but at least 3.0 and 3.1 would be nice. I already run it with 3.1 all the time so that should be safe.

@chelnak chelnak force-pushed the MAINT-fix_ci branch 2 times, most recently from cb372b0 to 885a443 Compare January 23, 2023 16:22
@chelnak
Copy link
Contributor Author

chelnak commented Jan 23, 2023

I don't mind about 3.2 (since I know it can break a lot), but at least 3.0 and 3.1 would be nice. I already run it with 3.1 all the time so that should be safe.

done

@LukasAud LukasAud merged commit db28d9f into main Jan 23, 2023
@LukasAud LukasAud deleted the MAINT-fix_ci branch January 23, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@LukasAud LukasAud LukasAud approved these changes

Assignees

@chelnak chelnak

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chelnak @ekohl @LukasAud