(GH-372) Reset min Ruby requirement #373
Conversation
Prior to this change the required Ruby version was set to greater than or equal to 2.7. This meant that the spec_helpers gem would not run on systems with Ruby 2.5. This change updates the required Ruby version so that Rubies 2.5 and above are compatibel. Additionally the following gems were downgraded for compatibility: * pathspec is now ~> 0.2 * puppet-lint is now ~> 2.5.2
chelnak
force-pushed
the
GH-372-reset_min_ruby_requirement
branch
from
a844a28
to
1013d7a
Compare
|
Why didn't CI run on this? I don't see any checks. https://github.com/puppetlabs/puppetlabs_spec_helper/blob/main/.github/workflows/ci.yml (or https://github.com/puppetlabs/cat-github-actions/blob/main/.github/workflows/gem_ci.yml) also doesn't appear to run in a matrix build so how do you know it actually works? |
|
CI had disabled itself which is annoying. I've re-enabled and made some updates in #GH-374. |
|
Ah yes, combining cron and PR testing in the same flow. I've been hit by that too. I recommend adding required checks to avoid it. In gha-puppet we have a dummy job that depends on all others, so you can simply make that required instead of the whole matrix: https://github.com/voxpupuli/gha-puppet/blob/a8fea30a9fcf14fd4cc9071c839e5a55d5dbab83/.github/workflows/beaker.yml#L140-L149 |
|
Nice I'll take a look |
Prior to this change the required Ruby version was set to greater than or equal to 2.7. This meant that the spec_helpers gem would not run on systems with Ruby 2.5.
This change updates the required Ruby version so that Rubies 2.5 and above are compatibel.
Additionally the following gems were downgraded for compatibility: