Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore plans folder and any subfolder #294

Merged
merged 2 commits into from
Nov 13, 2019
Merged

Ignore plans folder and any subfolder #294

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3862c8
Ignore plans folder and any subfolder
Oct 3, 2019
c1d23e1
Add `.vendor/**/*` for exclude in PuppetSyntax for rake tasks
Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/puppetlabs_spec_helper/rake_tasks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@
PuppetSyntax.exclude_paths << 'spec/fixtures/**/*'
PuppetSyntax.exclude_paths << 'pkg/**/*'
PuppetSyntax.exclude_paths << 'vendor/**/*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst you're at it, could you also add .vendor/**/*? This is already in the puppet-lint ignore_paths, but missing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexjfisher, I see your point, why would we have Puppet Code in a .vendor repo, every time I have used a .vendor it has been for Ruby Gems. I am fine making this change but for Puppet Syntax I am scratching my head as to why we would hide modules in .vendor

PuppetSyntax.exclude_paths << 'plans/*'
PuppetSyntax.exclude_paths << 'plans/**/*'
if Puppet.version.to_f < 4.0
PuppetSyntax.exclude_paths << 'types/**/*'
end
Expand Down