Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore plans folder and any subfolder #294

Merged
merged 2 commits into from
Nov 13, 2019
Merged

Ignore plans folder and any subfolder #294

merged 2 commits into from
Nov 13, 2019

Conversation

cyberious
Copy link
Contributor

No description provided.

@cyberious cyberious requested a review from a team as a code owner October 3, 2019 21:41
@codecov-io
Copy link

codecov-io commented Oct 3, 2019

Codecov Report

Merging #294 into master will decrease coverage by 1.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   44.88%   43.82%   -1.06%     
==========================================
  Files          11       11              
  Lines         782      826      +44     
==========================================
+ Hits          351      362      +11     
- Misses        431      464      +33
Impacted Files Coverage Δ
lib/puppetlabs_spec_helper/rake_tasks.rb 41.53% <100%> (-6.34%) ⬇️
lib/puppetlabs_spec_helper/tasks/fixtures.rb 38% <0%> (+2.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d66ff5...c1d23e1. Read the comment docs.

@@ -220,7 +220,7 @@
PuppetSyntax.exclude_paths << 'spec/fixtures/**/*'
PuppetSyntax.exclude_paths << 'pkg/**/*'
PuppetSyntax.exclude_paths << 'vendor/**/*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst you're at it, could you also add .vendor/**/*? This is already in the puppet-lint ignore_paths, but missing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexjfisher, I see your point, why would we have Puppet Code in a .vendor repo, every time I have used a .vendor it has been for Ruby Gems. I am fine making this change but for Puppet Syntax I am scratching my head as to why we would hide modules in .vendor

@lionce
Copy link
Contributor

lionce commented Nov 7, 2019

Hello @cyberious ,

Would you please check the comments? We appreciate your help and support! Thanks!

Cheers!

@cyberious
Copy link
Contributor Author

@lionce commented above and added change

@lionce
Copy link
Contributor

lionce commented Nov 13, 2019

Hello @cyberious ,

Thank you! Appreciate your help and patience.

Cheers!

@lionce lionce merged commit 2e2a612 into puppetlabs:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants