-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore plans folder and any subfolder #294
Conversation
Codecov Report
@@ Coverage Diff @@
## master #294 +/- ##
==========================================
- Coverage 44.88% 43.82% -1.06%
==========================================
Files 11 11
Lines 782 826 +44
==========================================
+ Hits 351 362 +11
- Misses 431 464 +33
Continue to review full report at Codecov.
|
@@ -220,7 +220,7 @@ | |||
PuppetSyntax.exclude_paths << 'spec/fixtures/**/*' | |||
PuppetSyntax.exclude_paths << 'pkg/**/*' | |||
PuppetSyntax.exclude_paths << 'vendor/**/*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whilst you're at it, could you also add .vendor/**/*
? This is already in the puppet-lint ignore_paths, but missing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alexjfisher, I see your point, why would we have Puppet Code in a .vendor
repo, every time I have used a .vendor
it has been for Ruby Gems. I am fine making this change but for Puppet Syntax I am scratching my head as to why we would hide modules in .vendor
Hello @cyberious , Would you please check the comments? We appreciate your help and support! Thanks! Cheers! |
@lionce commented above and added change |
Hello @cyberious , Thank you! Appreciate your help and patience. Cheers! |
No description provided.