Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "(feat) dont load the beaker if litmus is there" #286

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

pmcmaw
Copy link
Contributor

@pmcmaw pmcmaw commented Mar 26, 2019

Reverts #281
This is due to the breakage caused by #281

@codecov-io
Copy link

codecov-io commented Mar 26, 2019

Codecov Report

Merging #286 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #286   +/-   ##
=======================================
  Coverage   44.88%   44.88%           
=======================================
  Files          11       11           
  Lines         782      782           
=======================================
  Hits          351      351           
  Misses        431      431
Impacted Files Coverage Δ
lib/puppetlabs_spec_helper/rake_tasks.rb 47.86% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 963a950...2642beb. Read the comment docs.

@pmcmaw pmcmaw requested a review from tphoney March 26, 2019 15:10
@tphoney
Copy link
Contributor

tphoney commented Mar 26, 2019

merging, unless you have objections @ekohl

@ekohl
Copy link
Contributor

ekohl commented Mar 26, 2019

I appreciate the quick turnaround.

@tphoney tphoney merged commit 239bd0a into master Mar 26, 2019
@tphoney tphoney added the bug label Mar 26, 2019
@puppetcla
Copy link

CLA signed by all contributors.

@pmcmaw
Copy link
Contributor Author

pmcmaw commented Mar 26, 2019

@ekohl this has now been released and can be found on Rubygems as v2.14.1.
Apologies for that! 👍

@DavidS DavidS deleted the revert-281-FM-7847 branch January 18, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants