Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) dont load the beaker if litmus is there #281

Merged
merged 1 commit into from
Mar 21, 2019
Merged

(feat) dont load the beaker if litmus is there #281

merged 1 commit into from
Mar 21, 2019

Conversation

tphoney
Copy link
Contributor

@tphoney tphoney commented Mar 7, 2019

No description provided.

@puppetcla
Copy link

CLA signed by all contributors.

@tphoney tphoney changed the title (feat) dont load the beaker if litmus is there {WIP} (feat) dont load the beaker if litmus is there Mar 14, 2019
@codecov-io
Copy link

codecov-io commented Mar 14, 2019 •
edited
Loading

Codecov Report

Merging #281 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   44.88%   44.88%           
=======================================
  Files          11       11           
  Lines         782      782           
=======================================
  Hits          351      351           
  Misses        431      431
Impacted Files Coverage Δ
lib/puppetlabs_spec_helper/rake_tasks.rb 47.86% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f4c0e...9f68241. Read the comment docs.

@tphoney tphoney changed the title {WIP} (feat) dont load the beaker if litmus is there (feat) dont load the beaker if litmus is there Mar 14, 2019
@pmcmaw
Copy link
Contributor

pmcmaw commented Mar 21, 2019

This change LGTM. This change is required for progression of puppet-litmus.

@pmcmaw pmcmaw merged commit 24971be into puppetlabs:master Mar 21, 2019
ekohl
ekohl reviewed Mar 25, 2019
View reviewed changes
lib/puppetlabs_spec_helper/rake_tasks.rb
require 'puppetlabs_spec_helper/tasks/fixtures'
require 'puppetlabs_spec_helper/tasks/check_symlinks'
require 'English'

# dont load beaker if litmus is present
require 'puppetlabs_spec_helper/tasks/beaker' unless Bundler.rubygems.find_name('puppet_litmus').any?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke: NameError: uninitialized constant Bundler

Rakefile and Gemfile for reference.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting us know @ekohl
We will work on a fix and have it released as soon as we possibly can.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Perhaps it should check if beaker is actually present? In many cases people just exclude beaker unless they're running acceptance tests in their Gemfiles.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue is being tracked here: https://tickets.puppetlabs.com/browse/MODULES-8778
:-)

This was referenced Mar 26, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmcmaw pmcmaw pmcmaw left review comments

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tphoney @puppetcla @codecov-io @pmcmaw @ekohl