(maint) load rake tasks from optional libraries #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need for the same loading code in pdk-templates at https://github.com/puppetlabs/pdk-templates/blob/7281db56ead0feeacbc70e5d5dfb3bb885c554ba/moduleroot/Rakefile.erb#L13-L16 Note that `puppet-syntax/tasks/puppet-syntax` was already loaded in this file further down.
|
This supercedes #274 |
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 44.45% 44.88% +0.42%
==========================================
Files 11 11
Lines 776 782 +6
==========================================
+ Hits 345 351 +6
Misses 431 431
Continue to review full report at Codecov.
|
ekohl
approved these changes
Feb 15, 2019
|
CLA signed by all contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for the same loading code in pdk-templates at
https://github.com/puppetlabs/pdk-templates/blob/7281db56ead0feeacbc70e5d5dfb3bb885c554ba/moduleroot/Rakefile.erb#L13-L16
Note that
puppet-syntax/tasks/puppet-syntaxwas already loaded in thisfile further down.