Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load puppet-strings tasks when available #274

Closed
wants to merge 2 commits into from

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Jan 11, 2019

This provides the string:generate task which can be useful for module developers.

This provides the string:generate task which can be useful for module
developers.
@codecov-io
Copy link

codecov-io commented Jan 11, 2019

Codecov Report

Merging #274 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #274      +/-   ##
=========================================
+ Coverage   44.45%   44.6%   +0.14%     
=========================================
  Files          11      11              
  Lines         776     778       +2     
=========================================
+ Hits          345     347       +2     
  Misses        431     431
Impacted Files Coverage Δ
lib/puppetlabs_spec_helper/rake_tasks.rb 46.85% <100%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926fb06...071d95f. Read the comment docs.

@puppetcla
Copy link

Waiting for CLA signature by @ekohl

@ekohl - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

@ekohl
Copy link
Contributor Author

ekohl commented Jan 13, 2019

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

White this patch does introduce a new feature, it's still trivial IMHO.

@ekohl
Copy link
Contributor Author

ekohl commented Feb 15, 2019

Closing in favor of #279

@ekohl ekohl closed this Feb 15, 2019
@ekohl ekohl deleted the optionally-load-puppet-strings branch February 15, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants