Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-997) Remove Dir.chdir call from check:test_file task #266

Merged
merged 1 commit into from
Dec 8, 2018

Commits on Dec 6, 2018

  1. (PDK-997) Remove Dir.chdir call from check:test_file task

    This `chdir` breaks the isolation of the rake task and affects the
    behaviour of other tasks that are invoked in it in the same `rake`
    execution.
    
    Rather than modify the task so that it changes back to the parent
    directory after the task has finished, we can just remove the `chdir`
    entirely and just change the glob to look for files in the directory.
    
    This PR also adds some basic unit tests for the `check:test_file` task.
    rodjek committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    4a85db6 View commit details
    Browse the repository at this point in the history