(PDK-997) Remove Dir.chdir call from check:test_file task #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
+ Coverage 40.97% 41.61% +0.63%
==========================================
Files 10 10
Lines 759 757 -2
==========================================
+ Hits 311 315 +4
+ Misses 448 442 -6
Continue to review full report at Codecov.
|
This `chdir` breaks the isolation of the rake task and affects the behaviour of other tasks that are invoked in it in the same `rake` execution. Rather than modify the task so that it changes back to the parent directory after the task has finished, we can just remove the `chdir` entirely and just change the glob to look for files in the directory. This PR also adds some basic unit tests for the `check:test_file` task.
|
CLA signed by all contributors. |
|
@rodjek This seems like a sensible change to me. It's admittedly my first interaction with this codebase though, so feel free to pull in another reviewer if you'd like to get any additional eyes on it. |
nkanderson
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
chdirbreaks the isolation of the rake task and affects thebehaviour of other tasks that are invoked in it in the same
rakeexecution.
Rather than modify the task so that it changes back to the parent
directory after the task has finished, we can just remove the
chdirentirely and just change the glob to look for files in the directory.
This PR also adds some basic unit tests for the
check:test_filetask.