(maint) Validate fact_on name parameter

[alexjfisher]

Since #59 fact_on
stopped working with symbols for fact names. (The documentation says it takes a String for name so only worked by chance previously).

In puppet/collectd we had a test that had started failing (easy enough to fix), and some that were being silently skipped. voxpupuli/puppet-collectd#858

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[mchllweeks]

@alexjfisher In order to get this ready for merging, we'll need these tasks to be done for this PR:

• add a spec test so that we don't break this functionality in the future
• pre-pend your ticket ref to your git commit message
• add a changelog entry to the CHANGELOG file so this will be reported with the release that it's in

Once those are complete, we can run tests and move this towards release. Thx!

[alexjfisher]

@mchllweeks I can add a spec test and open a BKR ticket (or could this one liner go in as a ‘maint’ change?), but this project doesn’t appear to have a CHANGELOG.

[mchllweeks]

@alexjfisher Yes sorry the CHANGELOG is just for beaker and not beaker-puppet. Pre-pending your commit with '(maint)' is also fine.

[alexjfisher]

@mchllweeks Test added and commit prepended with (maint).

[mchllweeks]

Jenkins test this please