(BKR-1510) make fact helpers support structured facts #59
Conversation
|
Can one of the admins verify this patch? |
|
jenkins test this please |
|
@mchllweeks I run rake test:spec:run locally and get this: I can't see the Jenkins result details on this PR other than it is failing. Should I be running some other test? |
|
@sevendials Here is the error from Jenkins: |
This code adds json to the options of fact_on() and parses the result. This means that fact() and fact_on() preserve the structure and data types of facts.
sevendials
force-pushed
the
structured_facts
branch
from
73f1bb7
to
3bff9b9
Compare
|
@mchllweeks I couldn't find any docs about appropriate Ruby versions but I'm guessing that Jenkins is using Ruby <2.4 because above that, Fixnum is deprecated. I've rebased and pushed a fix to it. |
|
jenkins test this please |
|
jenkins re-test this please |
Since puppetlabs#59 `fact_on` stopped working with symbols for fact names.
Since puppetlabs/beaker-puppet#59, `fact` no longer works with symbols. One test was failing. Two others were being skipped entirely.
Since puppetlabs#59 `fact_on` stopped working with symbols for fact names.
Since puppetlabs/beaker-puppet#59, `fact` no longer works with symbols. One test was failing. Two others were being skipped entirely.
This code adds json to the options of fact_on() and parses the result. This means that fact() and fact_on() preserve the structure and data types of facts.