-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep the sdk version inline with the bridge #189
Conversation
This removes the `--kind=sdk` option from the tool. We already have functionality to bring the pkg+sdk version in all places up to what the bridge requires. Fixes #184
I'm a little confused here as it removes the ability to update SDK completely. Is that too much? Does it update the SDK as part of the "bridge" or "all" update? perhaps just dropping that from "all" suffices to not run it until asked to? |
I thought about dropping It's not a safe upgrade, since sometimes |
Hm, that's reasonable but how about upgrading native providers that have no bridge? I guess we can deal with that when we need to. I was also thinking to consider to make it triple-certain, basically "ensure", the invariant that {pkg,sdk} dependency is strictly never ahead (or is equal) to the bridge's {pkg,sdk} dependency. But this automation can get in the way of mowing down custom go.mod setups. |
This tool really doesn't work on native providers (calling
I don't think that is necessary right now. If the only thing that upgrades |
This is a pure refractor for testability. There should be no user facing changes. This PR is stacked on top of #189.
This removes the
--kind=sdk
option from the tool.We already have functionality to bring the pkg+sdk version in all places up to what the bridge requires.
Fixes #184