Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not upgrade pulumi/pkg and pulumi/sdk ahead of the bridge #184

Closed
t0yv0 opened this issue Oct 18, 2023 · 3 comments · Fixed by #189
Closed

Do not upgrade pulumi/pkg and pulumi/sdk ahead of the bridge #184

t0yv0 opened this issue Oct 18, 2023 · 3 comments · Fixed by #189
Assignees
@iwahbe
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@t0yv0
Copy link
Member

t0yv0 commented Oct 18, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

This is contrary to prior requests originating from me, but I believe at the moment our deployment pipeline would benefit from never upgrading pulumi/pkg references (which installs codegen fixes) ahead of what was tested in pulumi-terraform-bridge. This makes sure additional bridge release checks such as this qualify the codegen changes on actual provider test-suites.

Affected area/feature
@t0yv0 t0yv0 added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Oct 18, 2023
@mikhailshilkov mikhailshilkov removed the needs-triage Needs attention from the triage team label Oct 18, 2023
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 24, 2023

There's some additional requirements here I think. @justinvp attempted to pre-test pulumi/pkg changes before they get released through a workflow including upgrade-provider, but the PRs failed for example:

https://github.com/pulumi/pulumi-docker/actions/runs/6631589650/job/18015417451

The workflow tested was https://github.com/pulumi/pulumi-terraform-bridge/actions/workflows/update-providers-test.yml

I think the issue here is that upgrade-provider didn't respect the pre-release pulumi/pkg version that was referenced by the bridge update, thus the builds run into a compilation error.

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 24, 2023

@mikhailshilkov @iwahbe can we expedite this? This is hopefully a very small but very impactful change, without this change the bridge reliability initiative that installed https://github.com/pulumi/pulumi-terraform-bridge/actions/workflows/update-providers-test.yml into the bridge release workflows is unable to prevent pulumi/pkg updates from going out ahead of the testing.

@iwahbe iwahbe self-assigned this Oct 25, 2023
iwahbe added a commit that referenced this issue Oct 25, 2023
@iwahbe
Keep the sdk version inline with the bridge
e4fa994 
This removes the `--kind=sdk` option from the tool.

We already have functionality to bring the pkg+sdk version in all places up to what the
bridge requires.

Fixes #184
@iwahbe iwahbe mentioned this issue Oct 25, 2023
Merged
@iwahbe
Copy link
Member

iwahbe commented Oct 25, 2023

Done. @guineveresaenger added a function to adjust all pkg+sdk references to what provider/go.mod uses, so this is just deleting some code.

@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwahbe iwahbe

Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep the sdk version inline with the bridge pulumi/upgrade-provider
4 participants
@t0yv0 @mikhailshilkov @iwahbe @pulumi-bot