Pass state back to the engine if Apply encountered an error 2

[VenelinMartinov]

In the SDKv2 bridge under PlanResourceChange we are not passing any state we receive during TF Apply back to the engine if we also received an error. This causes us to incorrectly miss any resources which were created but encountered errors during the creation process. The engine should see these as ResourceInitError, which allows the engine to attempt to update the partially created resource on the next up.

This PR fixes the issue by passing the state down to the engine in the case when we receive an error and a non-nil state from TF during Apply.

This is the second attempt at this. The first was #2695 but was reverted because it caused a different panic: #2706. We added a regression test for that in #2710

The reason for that panic was that we were now creating a non-nil InstanceState with a nil stateValue which causes the ID function to panic. This PR fixes both issues by not allowing non-nil states with nil stateValues and by preventing the panic in ID.

There was also a bit of fun with go nil interfaces along the way, which is the reason why ApplyResourceChange now returns a shim.InstanceState interface instead of a *v2InstanceState2. Otherwise we end up creating a non-nil interface with a nil value.

related to pulumi/pulumi-gcp#2700
related to pulumi/pulumi-aws#4759

fixes #2696

[VenelinMartinov]

This change is part of the following stack:

• Pass state back to the engine if Apply encountered an error 2 #2713 ◀

_{Change managed by git-spice.}

[codecov]

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.56%. Comparing base (334d6b7) to head (0c78935).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/tfshim/sdk-v2/provider2.go	72.72%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2713      +/-   ##
==========================================
+ Coverage   69.53%   69.56%   +0.03%     
==========================================
  Files         301      301              
  Lines       38655    38654       -1     
==========================================
+ Hits        26878    26890      +12     
+ Misses      10257    10244      -13     
  Partials     1520     1520              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pulumi-bot]

This PR has been shipped in release v3.98.0.