Revert "Pass state back to the engine if Apply encountered an error" #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
approved these changes
Dec 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2707 +/- ##
==========================================
- Coverage 69.51% 69.47% -0.05%
==========================================
Files 301 301
Lines 38637 38644 +7
==========================================
- Hits 26860 26847 -13
- Misses 10256 10272 +16
- Partials 1521 1525 +4 ☔ View full report in Codecov by Sentry. |
|
This PR has been shipped in release v3.97.1. |
VenelinMartinov
added a commit
that referenced
this pull request
Dec 10, 2024
VenelinMartinov
added a commit
that referenced
this pull request
Dec 10, 2024
VenelinMartinov
added a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2695
Fixes #2706