Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out non-deterministic test #2327

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

VenelinMartinov
Copy link
Contributor

Comment out non-deterministic test.

This one was missed in #2159

Tracked in #2325

fixes #2326

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.98%. Comparing base (5f67f63) to head (12fb009).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2327      +/-   ##
==========================================
- Coverage   57.44%   56.98%   -0.47%     
==========================================
  Files         365      366       +1     
  Lines       41841    50056    +8215     
==========================================
+ Hits        24037    28524    +4487     
- Misses      16235    19964    +3729     
+ Partials     1569     1568       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov requested a review from a team August 20, 2024 13:09
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the non-determinism from the provider or the engine?

If it's from the provider, can we simply provide an arbitrary ordering?

If not, is there an associated issue in pulumi/pulumi?

@VenelinMartinov
Copy link
Contributor Author

It's from the bridge, tracked in #2325, will be fixed by #2294

@VenelinMartinov VenelinMartinov merged commit 278e894 into master Aug 20, 2024
11 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/fix_comment_nondeterministic_test branch August 20, 2024 14:17
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! You can also introduce skipped: True and t.Skip() to avoid the larger diffs. (nit).

@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.90.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failure: Master and Tag Builds
4 participants