Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-deterministic detailed diff output for set element addition/removal #2325

Closed
VenelinMartinov opened this issue Aug 20, 2024 · 1 comment · Fixed by #2405
Closed

Non-deterministic detailed diff output for set element addition/removal #2325

VenelinMartinov opened this issue Aug 20, 2024 · 1 comment · Fixed by #2405
Assignees
@VenelinMartinov
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@VenelinMartinov
Copy link
Contributor

What happened?

The detailed diff output for set element addition/removal is non deterministic.

Discovered in #2159

Example

The output of TestDetailedDiffPlainTypes/set_element_added_front oscillates between:

  ~ setProps: [
      ~ [0]: "val2" => "val1"
      ~ [1]: "val3" => "val2"
      + [2]: "val3"

and

  ~ setProps: [
      + [0]: "val1"
      ~ [1]: "val3" => "val2"
      + [2]: "val3"
    ]

The outputs of the other set element tests are also non-deterministic.

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@VenelinMartinov VenelinMartinov added the kind/bug Some behavior is incorrect or out of spec label Aug 20, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Aug 20, 2024
@VenelinMartinov VenelinMartinov mentioned this issue Aug 20, 2024
Merged
@VenelinMartinov VenelinMartinov removed the needs-triage Needs attention from the triage team label Aug 20, 2024
@VenelinMartinov VenelinMartinov mentioned this issue Aug 20, 2024
Merged
VenelinMartinov added a commit that referenced this issue Aug 20, 2024
@VenelinMartinov
Comment out non-deterministic test (#2327)
278e894 
Comment out non-deterministic test.

This one was missed in
#2159

Tracked in #2325

fixes #2326
@VenelinMartinov VenelinMartinov mentioned this issue Sep 24, 2024
Merged
@pulumi-bot pulumi-bot added resolution/fixed This issue was fixed labels Oct 1, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #2405 and shipped in release v3.92.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VenelinMartinov VenelinMartinov

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
2 participants
@VenelinMartinov @pulumi-bot