-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a goldmark parser extension for first class sections #2306
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2306 +/- ##
==========================================
+ Coverage 56.83% 57.37% +0.53%
==========================================
Files 362 364 +2
Lines 49886 49445 -441
==========================================
+ Hits 28354 28368 +14
+ Misses 19987 19530 -457
- Partials 1545 1547 +2 ☔ View full report in Codecov by Sentry. |
32e8e2f
to
9e1c136
Compare
9e1c136
to
9b15805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows us to clean up the logic for skipSectionByHeader.
9b15805
to
8ffa9bd
Compare
bca1b79
to
353d660
Compare
Fixes #4342 The fix is inherited through the pulumi/pulumi-terraform-bridge@e468215 commit This change bypasses our normal process of waiting for the next pulumi-terraform-bridge release to accelerate landing the fix. The changes between 3.89.0 and e4682154f1735880a1376774ccb593b4523410fe appear to be low-risk: - pulumi/pulumi-terraform-bridge#2306 - pulumi/pulumi-terraform-bridge#2292
Adds section as a first class node kind in goldmark.
The test shows how sections are useful for manipulating the AST, since they encapsulate a header and it's children.