Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a goldmark parser extension for first class sections #2306

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Aug 12, 2024

Adds section as a first class node kind in goldmark.

The test shows how sections are useful for manipulating the AST, since they encapsulate a header and it's children.

@iwahbe iwahbe self-assigned this Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.37%. Comparing base (30a3a41) to head (f0483ae).

Files Patch % Lines
pkg/tfgen/parse/section/section.go 90.90% 4 Missing ⚠️
pkg/tfgen/parse/extension.go 89.28% 2 Missing and 1 partial ⚠️
pkg/tfgen/installation_docs.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2306      +/-   ##
==========================================
+ Coverage   56.83%   57.37%   +0.53%     
==========================================
  Files         362      364       +2     
  Lines       49886    49445     -441     
==========================================
+ Hits        28354    28368      +14     
+ Misses      19987    19530     -457     
- Partials     1545     1547       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iwahbe iwahbe force-pushed the iwahbe/first-class-sections branch from 32e8e2f to 9e1c136 Compare August 12, 2024 12:02
@iwahbe iwahbe force-pushed the iwahbe/first-class-sections branch from 9e1c136 to 9b15805 Compare August 12, 2024 12:04
Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows us to clean up the logic for skipSectionByHeader.

@iwahbe iwahbe force-pushed the iwahbe/first-class-sections branch from 9b15805 to 8ffa9bd Compare August 12, 2024 13:33
@iwahbe iwahbe force-pushed the iwahbe/first-class-sections branch from bca1b79 to 353d660 Compare August 12, 2024 14:53
@iwahbe iwahbe enabled auto-merge (squash) August 12, 2024 15:01
@iwahbe iwahbe merged commit 5548bd6 into master Aug 12, 2024
11 checks passed
@iwahbe iwahbe deleted the iwahbe/first-class-sections branch August 12, 2024 15:17
t0yv0 added a commit to pulumi/pulumi-aws that referenced this pull request Aug 14, 2024
Fixes #4342 

The fix is inherited through the
pulumi/pulumi-terraform-bridge@e468215
commit

This change bypasses our normal process of waiting for the next
pulumi-terraform-bridge release to accelerate landing the fix. The
changes between 3.89.0 and e4682154f1735880a1376774ccb593b4523410fe
appear to be low-risk:

- pulumi/pulumi-terraform-bridge#2306
- pulumi/pulumi-terraform-bridge#2292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants