-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type-checking booleans #4368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flostadler
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/release patch |
github-actions
bot
added
the
needs-release/patch
When a PR with this label merges, it initiates a release of vX.Y.Z+1
label
Aug 14, 2024
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
github-actions
bot
removed
the
needs-release/patch
When a PR with this label merges, it initiates a release of vX.Y.Z+1
label
Aug 14, 2024
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Aug 17, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | patch | [`6.49.0` -> `6.49.1`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.49.0/6.49.1) | --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.49.1`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.49.1) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.49.0...v6.49.1) ##### Does the PR have any schema changes? Looking good! No breaking changes found. No new resources/functions. ##### What's Changed - Upgrade pulumi-terraform-bridge to v3.89.0 by [@​iwahbe](https://togithub.com/iwahbe) in [https://github.com/pulumi/pulumi-aws/pull/4363](https://togithub.com/pulumi/pulumi-aws/pull/4363) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4364](https://togithub.com/pulumi/pulumi-aws/pull/4364) - Fix type-checking booleans by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/4368](https://togithub.com/pulumi/pulumi-aws/pull/4368) **Full Changelog**: pulumi/pulumi-aws@v6.49.0...v6.49.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4zMS4wIiwidXBkYXRlZEluVmVyIjoiMzguMzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9wYXRjaCJdfQ==--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Aug 17, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | patch | [`6.49.0` -> `6.49.1`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.49.0/6.49.1) | --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.49.1`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.49.1) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.49.0...v6.49.1) ##### Does the PR have any schema changes? Looking good! No breaking changes found. No new resources/functions. ##### What's Changed - Upgrade pulumi-terraform-bridge to v3.89.0 by [@​iwahbe](https://togithub.com/iwahbe) in [https://github.com/pulumi/pulumi-aws/pull/4363](https://togithub.com/pulumi/pulumi-aws/pull/4363) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4364](https://togithub.com/pulumi/pulumi-aws/pull/4364) - Fix type-checking booleans by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/4368](https://togithub.com/pulumi/pulumi-aws/pull/4368) **Full Changelog**: pulumi/pulumi-aws@v6.49.0...v6.49.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4zMS4wIiwidXBkYXRlZEluVmVyIjoiMzguMzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9wYXRjaCJdfQ==--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4342
The fix is inherited through the pulumi/pulumi-terraform-bridge@e468215 commit
This change bypasses our normal process of waiting for the next pulumi-terraform-bridge release to accelerate landing the fix. The changes between 3.89.0 and e4682154f1735880a1376774ccb593b4523410fe appear to be low-risk: