Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type-checking booleans #4368

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fix type-checking booleans #4368

merged 1 commit into from
Aug 14, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Aug 14, 2024

Fixes #4342

The fix is inherited through the pulumi/pulumi-terraform-bridge@e468215 commit

This change bypasses our normal process of waiting for the next pulumi-terraform-bridge release to accelerate landing the fix. The changes between 3.89.0 and e4682154f1735880a1376774ccb593b4523410fe appear to be low-risk:

@t0yv0 t0yv0 requested review from flostadler and corymhall August 14, 2024 14:08
Copy link
Contributor

@flostadler flostadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@t0yv0 t0yv0 enabled auto-merge (squash) August 14, 2024 14:09
@t0yv0
Copy link
Member Author

t0yv0 commented Aug 14, 2024

/release patch

@github-actions github-actions bot added the needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1 label Aug 14, 2024
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0 t0yv0 merged commit 872346b into master Aug 14, 2024
31 checks passed
@t0yv0 t0yv0 deleted the t0yv0/fix-4342 branch August 14, 2024 15:46
@github-actions github-actions bot removed the needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1 label Aug 14, 2024
lumiere-bot bot referenced this pull request in coolguy1771/home-ops Aug 17, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@pulumi/aws](https://pulumi.io)
([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies |
patch | [`6.49.0` ->
`6.49.1`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.49.0/6.49.1)
|

---

### Release Notes

<details>
<summary>pulumi/pulumi-aws (@&#8203;pulumi/aws)</summary>

###
[`v6.49.1`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.49.1)

[Compare
Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.49.0...v6.49.1)

##### Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

##### What's Changed

- Upgrade pulumi-terraform-bridge to v3.89.0 by
[@&#8203;iwahbe](https://togithub.com/iwahbe) in
[https://github.com/pulumi/pulumi-aws/pull/4363](https://togithub.com/pulumi/pulumi-aws/pull/4363)
- Update GitHub Actions workflows. by
[@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in
[https://github.com/pulumi/pulumi-aws/pull/4364](https://togithub.com/pulumi/pulumi-aws/pull/4364)
- Fix type-checking booleans by
[@&#8203;t0yv0](https://togithub.com/t0yv0) in
[https://github.com/pulumi/pulumi-aws/pull/4368](https://togithub.com/pulumi/pulumi-aws/pull/4368)

**Full Changelog**:
pulumi/pulumi-aws@v6.49.0...v6.49.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4zMS4wIiwidXBkYXRlZEluVmVyIjoiMzguMzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9wYXRjaCJdfQ==-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot referenced this pull request in coolguy1771/home-ops Aug 17, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@pulumi/aws](https://pulumi.io)
([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies |
patch | [`6.49.0` ->
`6.49.1`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.49.0/6.49.1)
|

---

### Release Notes

<details>
<summary>pulumi/pulumi-aws (@&#8203;pulumi/aws)</summary>

###
[`v6.49.1`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.49.1)

[Compare
Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.49.0...v6.49.1)

##### Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

##### What's Changed

- Upgrade pulumi-terraform-bridge to v3.89.0 by
[@&#8203;iwahbe](https://togithub.com/iwahbe) in
[https://github.com/pulumi/pulumi-aws/pull/4363](https://togithub.com/pulumi/pulumi-aws/pull/4363)
- Update GitHub Actions workflows. by
[@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in
[https://github.com/pulumi/pulumi-aws/pull/4364](https://togithub.com/pulumi/pulumi-aws/pull/4364)
- Fix type-checking booleans by
[@&#8203;t0yv0](https://togithub.com/t0yv0) in
[https://github.com/pulumi/pulumi-aws/pull/4368](https://togithub.com/pulumi/pulumi-aws/pull/4368)

**Full Changelog**:
pulumi/pulumi-aws@v6.49.0...v6.49.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4zMS4wIiwidXBkYXRlZEluVmVyIjoiMzguMzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9wYXRjaCJdfQ==-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: value has no attribute of that name for ecs.Service reported for a mis-typed Python program
2 participants